search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.25k stars 124 forks source link

PR creation doesn't recognize remote branch #400

Closed dominicmeyer closed 10 months ago

dominicmeyer commented 1 year ago

Issue Description

bug report

Describe what happened (or what feature you want)

I wanted to create a pull request with octo, but for some reason there was a message displayed, that the current branch has no remote and if I wanted to push the current one. The current brach was pulled from gh and also did pushes right before, so it was clearly connected. After restarting nvim I was able to create the pr.

Describe what you expected to happen

The pr creation was successful most of the time, so I didn't expect it to fail. Of course restarting nvim isn't that big of a deal, but it's just not convenient.

How to reproduce it (as minimally and precisely as possible)

I had the bug before, but sadly I don't know how to recreate it yet.

Tell us your environment

Windows 11 gh version 2.29.0 octo latest

Anything else we need to know?

Maybe this is an issue of gh cli?

pwntester commented 10 months ago

Thanks for reporting the issue and sorry for the late response. Are you still experiencing this bug? Remote branches are retrieved from the GH API. It is possible that if this request fails for whatever reason, it defaults to think that the remote does not exist. I just pushed a change to errout if the request fails. Please reopen if the problem persists