pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.25k stars 124 forks source link

`Octo repo list` throws error #401

Closed Subjective closed 1 year ago

Subjective commented 1 year ago

Issue Description

The :Octo repo list command throws the below error. For some reason, executing another command (e.g. :Octo search) beforehand allows it to work correctly.

Type: bug report

Describe what happened (or what feature you want)

Error message:
Error executing Lua callback: ...m/lazy/octo.nvim/lua/octo/pickers/telescope/provider.lua:925: bad argument #2 to 'graphql' (value expected)
stack traceback:
    [C]: in function 'graphql'
    ...m/lazy/octo.nvim/lua/octo/pickers/telescope/provider.lua:925: in function 'repos'
    ...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:138: in function 'a'
    ...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:356: in function 'octo'
    ...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:16: in function <...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:15>

Screen Recording 2023-05-29 at 10 21 36 PM

Describe what you expected to happen

I expect telescope to show a list of my repos.

How to reproduce it (as minimally and precisely as possible)

  1. :Octo repo list

Tell us your environment

MacOS 13.3 Neovim v0.9.1

Anything else we need to know?

pwntester commented 1 year ago

@Subjective thanks for reporting it. Can you try the fix and let me know if it works now for you?

Subjective commented 1 year ago

@pwntester It works now, thanks!

Edit: However, now the output is being printed out.

pwntester commented 1 year ago

My fault, I left a debug print around. should be ok now