highlighting of badges is funky?

[mizlan]

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

The badges use the special char but it's highlighted wrong.

Describe what you expected to happen

The badge should be properly highlighted (it seems Octo should tack on a default highlight group for this)

How to reproduce it (as minimally and precisely as possible)

1. Use Octo.nvim
2. Set colorscheme to Rose-pine or Everforest , seoul256, tokyonight (tested with those 4)
3. see it

Tell us your environment

unnecessary

Anything else we need to know?

[pwntester]

Hi, probably those themes are missing the Octo highlight groups. What are your colours for:

• OctoBubbleBlue
• OctoBubbleDelimiterBlue
• OctoBubbleYellow
• OctoBubbleDelimiterYellow
• OctoBubbleGreen
• OctoBubbleDelimiterGreen
• OctoBubbleRed
• OctoBubbleDelimiterRed

[rodhash]

Hey, amazing proejct!

Similar issue is happening here, in my case it seems to be a bit more broken.

iTerm 3.4.22 Nvim v0.9.4 Octo 5d6bed6

These are my colors (my custom teme):

I also tried other colorschemes such as gruvbox and tried using kitty instead but same issue. I even installed 4 or 5 different NF fonts but no luck so far.

any idea?

[rodhash]

Here a print screen w/ Kitty, Gruvbox, latest neovim nightly and a new NF:

[kezhenxu94]

For everyone in this thread, I've filed a PR (https://github.com/pwntester/octo.nvim/pull/456) to fix this, in case you want to verify.

[rodhash]

Thank you .. gave it a try and its looking way better now, some fonts now can render it but I just noticed something, apparently many other nerd fonts seem to have problem with this rounded char (including the font that I most enjoy lol)

One example is Hack font showing this very tiny "space" between the rounded char and the string:

Some fonts like Victor Mono seems to render it properly.. it's time to look for a new font I guess, or patching mine

[pwntester]

Thanks for the fix @kezhenxu94