pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.25k stars 124 forks source link

Improve background color #425

Closed joshmedeski closed 9 months ago

joshmedeski commented 9 months ago

Closes #424

Adjusting the get_background_color_of_highlight_group function to support cleared highlight groups.

Does this pull request fix one issue?

Resolves https://github.com/pwntester/octo.nvim/discussions/424

Special notes for reviews

Please let me know if the black background was intentional. And if so, what I would need to do to allow the get_background_color_of_highlight_group to return a cleared value so I can get a transparent UI.

pwntester commented 9 months ago

Thanks! it looks good to me. I guess I was using black as the fall safe option, but it makes sense to allow the color to be cleared

joshmedeski commented 9 months ago

No, thank YOU! I love using this plugin, such a time saver.

And thanks for the quick merge.