Closed joshmedeski closed 9 months ago
Thanks! it looks good to me. I guess I was using black as the fall safe option, but it makes sense to allow the color to be cleared
No, thank YOU! I love using this plugin, such a time saver.
And thanks for the quick merge.
Closes #424
Adjusting the
get_background_color_of_highlight_group
function to support cleared highlight groups.highlight_group_normal.foreground
is both confusing and makes it impossible to overwrite the default background value to a null value. So I've removed it.OctoEditable
highlight but the previous logic would still add a color back.Does this pull request fix one issue?
Resolves https://github.com/pwntester/octo.nvim/discussions/424
Special notes for reviews
Please let me know if the black background was intentional. And if so, what I would need to do to allow the
get_background_color_of_highlight_group
to return a cleared value so I can get a transparent UI.