pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.37k stars 127 forks source link

Remote branch error when creating PR #437

Closed vitorf7 closed 11 months ago

vitorf7 commented 11 months ago

Issue Description

Type: bug report

Describe what happened (or what feature you want)

Recently I have been getting a weird error where I get weird characters appearing when the Remote Branch step of the PR creation pops up. Whether I simply open :Octo or do :Octo pr create I get the same error as below: Screenshot 2023-10-17 at 18 20 16

Describe what you expected to happen

I expected the steps to ask what the remote branch, etc to work as it used to a few weeks ago

How to reproduce it (as minimally and precisely as possible)

  1. Open neovim and change a file.
  2. Open lazygit and push local changes to a new remote branch
  3. Run :Octo pr create

Tell us your environment

MacOS 14.0 Alacritty 0.12.3 Neovim

NVIM v0.10.0-dev-1080+g676e1d490
Build type: RelWithDebInfo
LuaJIT 2.1.1694316387

gh 2.36.0 (2023-10-03) octo master e933611c74cb735c00d0db8ca94533bec1444bf0

Anything else we need to know?

vitorf7 commented 11 months ago

Update:

This happened because I had no idea how to work with my new shell (fish). I had neofetch at the bottom of my config.fish but I just learned that this means it runs whether it is an interactive or non interactive shell. For other's benefits, the way I got this working was setting a variable in fish called fish_greeting. I had to do the following:

function fish_greeting
    neofetch
end

funcsave fish_greeting

Now I am trying to fix or find a way around a different problem 🤣 but at least hope this helps out others

pwntester commented 11 months ago

Thanks for sharing it here. Will close the issue but people with the same error should be able to find it.