Closed benelan closed 8 months ago
Thanks for the review. I added a util to convert vim style mappings to fzf ones and the spec tests I added are passing. I also installed fzf-lua and everything is working correctly. Let me know if any other changes are required!
Thanks, that looks great! Can you please fix the linter errors?
Woops, sorry about that. I also had to move the util for converting the mappings to the main util module because fzf-lua
is not installed for the tests. Everything should be passing now!
Thanks a lot!
Describe what this PR does / why we need it
Adds config options to change the telescope or fzf-lua mappings.
Does this pull request fix one issue?
Fixes #447
Describe how you did it
I added the the config options and used them in the telescope and fzf-lua picker code. I added a util, along with spec tests, that converts vim style mappings to fzf ones.
Describe how to verify it
pwntester/octo.nvim
tobenelan/octo.nvim
in your Neovim plugin configAdd the following to your Octo config
Octo pr list
Special notes for reviews
The
desc
property isn't used, but I added it to match the format of the other mappings in the config. Plus, Telescope may add the ability to use thedesc
for<C-/>
some day.Let me know if you'd like me to change anything about the config options I added, thanks for the review!