search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.36k stars 127 forks source link

Fix wrong bubble background colors #456

Closed kezhenxu94 closed 10 months ago

kezhenxu94 commented 10 months ago

Describe what this PR does / why we need it

This PR fixes the wrong bubble background colors, which should be introduced in https://github.com/pwntester/octo.nvim/pull/433

Does this pull request fix one issue?

Possibly fixes https://github.com/pwntester/octo.nvim/issues/412

Describe how you did it

Looks like vim.api.nvim_get_hl returns a different structure that contains { bg, fg } instead of { background, foreground }, this PR fixes the property names.

Describe how to verify it

image image

Special notes for reviews

rodhash commented 10 months ago

Hi

It seems 'CreatedBy' is having similar issues:

image
rodhash commented 10 months ago

Well in my test repo the "Created user" shows up ok, no issues .. but in this example from the Neorg repo, for some reason the "Created by" is like that.. it's using the HL group OctoBubble.

pwntester commented 10 months ago

Thanks, looks fine to me! As for the neorg issue it renders like this to me:

image

Note that user names use the OctoUser hl group. In my theme I use this

pwntester commented 10 months ago

@rodhash can you confirm if your problem is related with OctoUser hl group please?

rodhash commented 10 months ago

Hi @pwntester, yes this one too..

It seems to me we have two hl groups that apply to this situation, OctoUser as you mentioned but also OctoBubble .. both applies to field "Created by"