search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.36k stars 127 forks source link

Removed files not showing up in PR review panel #461

Closed Eryx5502 closed 8 months ago

Eryx5502 commented 10 months ago

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

When using Octo for reviewing a PR, I noticed that removed files doesn't show up on the bottom panel of the review layout, where all other modified files do appear. Unless I'm missing something, this makes impossible to know if you're missing some changes (i.e., the files removed completely) from the PR you're reviewing through Octo interface.

Describe what you expected to happen

I would expect the removed files appear on the bottom panel and once selected the upper right panel were empty while the upper left displayed the old (removed) version of the file.

How to reproduce it (as minimally and precisely as possible)

  1. Take a PR with deleted files among its changes.
  2. :Octo review start (actually, I did it resuming a review created from github web)
  3. Deleted files won't show in the bottom panel.

Tell us your environment

Nvim 0.10.0-dev inside WSL2

Anything else we need to know?

pwntester commented 8 months ago

Just tested with https://github.com/pwntester/octo-tests/pull/21 and I can see the removed file (test1.lua) in the changes panel:

Image

Is your PR public so I can take a look?

Eryx5502 commented 8 months ago

I'm not being able to reproduce it now, so maybe I misunderstood something when posting the issue. I'm closing then.