Closed milogert closed 8 months ago
@milogert I got some errors since the 4th property for the pull_request_query
and issue_query
queries was not always present. I made a global flag set on initialization and applied it on every PR/issue queries https://github.com/pwntester/octo.nvim/pull/477/commits/5f1fbf980295282b65b2e1e2f777dda7cb0fa867
Let me know if that looks good to you
@pwntester that flow looks great! There was one spot that I believe you missed in my latest commit
Thanks again for taking a look at this!
Thanks @milogert!
Describe what this PR does / why we need it
This PR is identical to #436 EXCEPT for the following:
gh
. I am on the fence about this particular feature, but it sort of tracks with the rest of the plugin world (i.e. restart Neovim after changes to see updates).ℹ️ The remainder of this description is just copy/pasted for documentation purposes.
This PR implements the projects v2 interface as well as the picker for fzf-lua.
Adds:
add
,move
, andremove
I went withset
andremove
. I The flow of projects v2 changed a bit andadd
andmove
felt a little too similar.default_to_projects_v2
, which makes thecard
command default to use projects v2. Both versions are still available under thecardlegacy
andcardv2
commands, regardless of this setting.Does this pull request fix one issue?
Addresses https://github.com/pwntester/octo.nvim/discussions/414
Describe how you did it
Followed the pattern of the other cards command. As noted above I changed the interface for the new command slightly, but to something that made sense to me and how projects v2 flowed.
Describe how to verify it
Mess around with projects v2 inside Octo. Everything should work as expected.
Special notes for reviews
I added two small additions as riders:
These are tiny changes that are just QoL adds for fzf-lua.
Also I updated the README to account for some fzf-lua changes as well.