search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.24k stars 124 forks source link

Show if PRs are drafts in PR picker #485

Open HampusMat opened 5 months ago

HampusMat commented 5 months ago

Issue Description

Type: bug report or feature request

feature request

Describe what happened (or what feature you want)

The pull request picker could show if pull requests are drafts. This would be extremely useful when picking a pull request to review. Currently you have to select a pull request to see if it is a draft (since it is not in previews) and if it is not you have to do :Octo pr list again and try the next one.

It would also be useful with a way to filter out draft pull requests but maybe that's a future feature?

The way to know if a pull request is a draft could maybe be a icon (configurable using setup)?

wd60622 commented 1 week ago

I am interested in implementing this (for telescope).

It seems to boil down to these symbols: https://github.com/wd60622/octo.nvim/blob/7731ca4e31b32c176a383642ffcd7d593ac17774/lua/octo/pickers/telescope/entry_maker.lua#L29-L29

Do you imagine this being a change in the symbol color? Or that there would be an additional column that would signify the draft status? I think the color would be most reflecting of GitHub's UI

Would this want to be configurable as well?