search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.36k stars 127 forks source link

fix: support large pull requests #508

Closed robsonpeixoto closed 5 months ago

robsonpeixoto commented 6 months ago

Does this pull request fix one issue?

Fixes #302

Describe how you did it

Instead of use the gh paginator, this module will paginate to the all files from a PR to avoid json_decode problem.

Describe how to verify it

Start/Resume a large pull-request

pwntester commented 6 months ago

Thanks! It would be nice if you could extract the pagination logic to the utils module so it could be reused by other methods in the future.

The pagination method could take the base URL, a table to hold aggregated responses and an aggregator function, eg: utils.aggregate(base_url, files, aggregator)

robsonpeixoto commented 5 months ago

Sorry, I'm without time to continue this PR.

Afourcat commented 4 months ago

Hello, Is there any reason, other than the OP being unable to continue, that led to the closing of this PR? This would be really helpful, as I'm currently unable to use Octo in my workflow. I may be able to allocate the time to finish the work of the OP in the following weeks, if necessary.

robsonpeixoto commented 4 months ago

This PR is not a elegant solution, @Afourcat. If you would like, feel free to open a new PR with the same content. Or even better, to follow the @pwntester suggestion.