search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.24k stars 124 forks source link

fix: improper gh cli flag for repo browser #512

Closed jemag closed 3 months ago

jemag commented 3 months ago

Describe what this PR does / why we need it

Flag -R does not exist with gh repo view

Does this pull request fix one issue?

Fixes #511

Describe how you did it

Removed flag

Describe how to verify it

  1. Octo repo view
  2. Octo repo browser

Special notes for reviews

jemag commented 3 months ago

Just realized it also does not work through Octo repo list and ctrl+b.

Command is cmd = string.format("gh repo view --web -R %s/%s", remote, repo)

But repo being passed is: image

Seems to work fine if I were to use cmd = string.format("gh repo view --web %s", repo.url) instead.

@pwntester Do you want me to make those changes as well as part of this PR?

pwntester commented 3 months ago

@pwntester Do you want me to make those changes as well as part of this PR?

Yep, please. You can also use repo.nameWithOwner but I think the URL is a better option here

jemag commented 3 months ago

done

pwntester commented 3 months ago

Thanks!