pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.36k stars 127 forks source link

Select item with enter does do nothing, picker fzf-lua (when checking the PR) #518

Open MadKuntilanak opened 6 months ago

MadKuntilanak commented 6 months ago

Issue Description

Type: bug report

Describe what happened (or what feature you want)

I use the default mapping list_changed_files <space>pf I can see what files are changed in the pupup fzf-lua window, when I press enter, it just does nothing.

Describe what you expected to happen

works as expected

How to reproduce it (as minimally and precisely as possible)

  1. Find and check pr list: octo pr list <repo>
  2. Use <space>pf to see changed files
  3. Select the item by pressing enter and...doing nothing?

Tell us your environment

neovim nightly: latest

local data = vim.fn.stdpath("data")
local lazypath = data .. "/lazy/lazy.nvim"

-- set stdpaths to use .repro
-- for _, name in ipairs({ "config", "data", "state", "cache" }) do
-- vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
-- end

-- bootstrap lazy
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end

vim.opt.runtimepath:prepend(lazypath)
vim.opt.clipboard = "unnamed"

vim.g.mapleader = " "
vim.g.maplocalleader = ","

-- local rg_opts = "--column --hidden --no-heading --ignore-case --smart-case --color=always --max-columns=4096 -e "

-- install plugins
local plugins = {
    "folke/tokyonight.nvim",
    {
        "pwntester/octo.nvim",
        cmd = "Octo",
        dependencies = {
            "nvim-telescope/telescope.nvim",
            "ibhagwan/fzf-lua",
        },
        opts = {
            picker = "fzf-lua", -- telescope
        },
    },
    {
        "nvim-telescope/telescope.nvim",
        version = false,
        cmd = "Telescope",
        dependencies = {
            "nvim-lua/plenary.nvim",
            { "nvim-telescope/telescope-fzf-native.nvim", build = "make", enabled = vim.fn.executable("make") == 1 },
        },
        keys = {},
        config = function()
            require("telescope").setup()
        end,
    },
    {
        "ibhagwan/fzf-lua",
        version = false,
        cmd = "FzfLua",
        event = "VeryLazy",
        keys = {
            { "<Leader>ff", "<CMD>FzfLua files<CR>", desc = "Fzflua: find files", mode = { "n", "v" } },
            { "<Leader>fC", "<CMD>FzfLua commands<CR>", desc = "Fzflua: commands", mode = "n" },
            { "<Leader>fh", "<CMD>FzfLua help_tags<CR>", desc = "Fzflua: help tags" },
            { "<Leader>fg", "<CMD>FzfLua live_grep<CR>", desc = "Fzflua: help tags" },
        },
        dependencies = {
            "sindrets/diffview.nvim",
            "nvim-tree/nvim-web-devicons",
            "onsails/lspkind.nvim",
        },
        opts = {},
        config = function()
            require("fzf-lua").setup()
        end,
    },
    -- add any other plugins here
}
require("lazy").setup(plugins, {
    root = lazypath .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
pwntester commented 6 months ago

@milogert Im assigning the fzf-lua issues to you but if you are busy just let me know, thanks!