search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.24k stars 124 forks source link

fix: fzf-lua multi select for some actions #527

Open milogert opened 3 months ago

milogert commented 3 months ago

⚠️ Relies on https://github.com/ibhagwan/fzf-lua/commit/8c76df67a5b3a0094fdf2256a5e30b7a830877f5

Describe what this PR does / why we need it

In some cases multiselect to send to the quickfix list makes sense. This enables that functionality.

Additionally, it stops using https://github.com/milogert/octo.nvim/blob/33d525b45062a84f9e6df42c6c2b17687cecd24f/lua/octo/pickers/fzf-lua/pickers/fzf_actions.lua#L1-L1 for the most part in exchange for using the built-in fzf-lua actions.

Does this pull request fix one issue?

Fixes https://github.com/pwntester/octo.nvim/issues/517

Describe how you did it

Reaserch, a bug fix in fzf-lua (https://github.com/ibhagwan/fzf-lua/pull/1099), and then replacing some actions with native equivalents.

Describe how to verify it

Functionality affected while using the fzf-lua picker:

Command `tab` to select multiple files `enter` on a single entry opens it `enter` with multiple selected sends to quickfix `ctrl-s` opens in splits `ctrl-v` opens in vert splits `ctrl-t` opens in tabs
`:Octo issue list`
Probably more... Standby

Special notes for reviews