search

pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.24k stars 124 forks source link

Diff wrong on some files #529

Open austinbutler opened 3 months ago

austinbutler commented 3 months ago

Issue Description

Type: bug report

Describe what happened (or what feature you want)

During PR review, on some files the syntax highlighting gets tripped up and it will consider the entire file new/changed.

Describe what you expected to happen

Only show the one line that changed as new instead of the whole file.

How to reproduce it (as minimally and precisely as possible)

I'm not sure on the repro, aside from:

  1. :Octo <url here>
  2. :Octo review start

Tell us your environment

Anything else we need to know?

The only config I've changed from default is set use_local_fs to true.

igorlfs commented 2 months ago

I'm also having this issue, though I haven't found a consistent reproduction. With you, does that always happen when reviewing large files?

austinbutler commented 2 months ago

I had thought so, but I hadn't been paying close attention. However right now it's happening on a file with only 290 lines. I've updated the issue to be more accurate given that.