pwntester / octo.nvim

Edit and review GitHub issues and pull requests from the comfort of your favorite editor
MIT License
2.24k stars 124 forks source link

Improve "Files Changed" active item visibility #534

Open joshmedeski opened 2 months ago

joshmedeski commented 2 months ago

Issue Description

Type: bug report

It is hard to tell which item is active in the "Files Changed" window.

SCR-20240416-jitd

Describe what happened (or what feature you want)

I expect the active item's highlight color to have enough contract from the default background color that it's legible.

How to reproduce it (as minimally and precisely as possible)

  1. View the "Files Changed" panel in a review
  2. Notice the background color on the currently selected item

Tell us your environment

Anything else we need to know?

I couldn't find a clearly labeled highlight color to overwrite this. While reviewing the codebase I couldn't make sense of the exact line that changes the currently selected (active?) item in the file changes window. So if you can point me in the right direction I don't mind making a PR.