search

pwollstadt / IDTxl

The Information Dynamics Toolkit xl (IDTxl) is a comprehensive software package for efficient inference of networks and their node dynamics from multivariate time series data using information theory.
http://pwollstadt.github.io/IDTxl/
GNU General Public License v3.0
249 stars 76 forks source link

Using Kraskov algorithm 2 #15

Closed pietromarchesi closed 6 years ago

pietromarchesi commented 6 years ago

To be able to use both Kraskov algorithms, I have written my own wrappers to the JIDT calculators, but perhaps it would be nice to be able to access both from IDTxl too? I was thinking of extending the IDTxl class for my own use, but if it's useful I could submit a PR.

jlizier commented 6 years ago

This is a nice idea. It's fairly straightforward to do, I'll just add a new option to the dictionary settings for each MI/CMI/TE calculator to specify the algorithm and instantiate the right calculator. Nothing else would need changing.

jlizier commented 6 years ago

Ok - Patricia I have code for this ready. Shall I push it along with the other changes we discussed recently re memory exhaustion or separately?

pwollstadt commented 6 years ago

Sounds good, thanks @pietromarchesi for bringing this up, and thanks @jlizier for the quick reply and implementation!

jlizier commented 6 years ago

Apologies for the delay in sending the PR through here, got caught up on other things as usual ...

pwollstadt commented 6 years ago

Merged PR #18 in commit 31d96672e2e359cad75092e18da6950fff43555f.