search

pwoolcoc / dhcp_parser

nom-based DHCP parser
MIT License
2 stars 5 forks source link

Issues with package #2

Open kpcyrd opened 7 years ago

kpcyrd commented 7 years ago

hey :)

It appears the version published to crates.io isn't compatible with rust stable:

error[E0554]: #[feature] may not be used on the stable release channel
 --> /some/path/.cargo/registry/src/github.com-1ecc6299db9ec823/dhcp_parser-0.1.0/src/lib.rs:1:1
  |
1 | #![feature(ip_addr)]
  | ^^^^^^^^^^^^^^^^^^^^

I think the correct way to check for features would be:

#[cfg(feature = "ip_addr")]

I also looked into the Cargo.toml, and found some more issues:

[dependencies]
nom = "*"
enum_primitive = "*"

[dependencies.num]
version = "*"
default-features = false

These should point to specific versions that dhcp_parser is compatible with. Also, the last dependency is pointing to a local path that doesn't exist on my system:

[dependencies.rest_easy]
path = "../rest_easy"

I'd really like to use your package, I'd greatly appreciate if you could look into this. Thanks! :)

pwoolcoc commented 7 years ago

It probably isn't a good idea to use this, I never did complete it. The parser currently doesn't parse anything from the vendor extensions portion of the RFC (https://tools.ietf.org/html/rfc2132#page-5)

I do have an updated branch where I get the current stuff working on stable, and the start of vendor extension support, but that is not ready for use yet.

kpcyrd commented 7 years ago

@pwoolcoc I see, thank you for the followup :)

pwoolcoc commented 7 years ago

@kpcyrd Thanks for your understanding, I apologize that you can't use it now. Hopefully I'll circle back around to it one day.