Closed SlySven closed 2 years ago
PR #1725 allows the config panel to scroll. Try it out and see whether it solves your problem.
To clone and use Solar from its GitHub repository
git clone https://github.com/pwr-Solaar/Solaar.git
cd Solaar
Run Solaar as bin/solaar from this directory.
To run PR #1725, first clone Solaar if you have not already done so and cd to the clone directory. The first time you download the pull request, fetch it into a new branch and checkout that branch, as in:
git fetch origin pull/1725/head:pull_1725
git checkout pull_1725
To download a new version of the pull request, fetch it and then set your pull branch to the new fetch, as in:
git checkout pull_1725
git fetch origin pull/1725/head
git reset --hard FETCH_HEAD
@SlySven Does PR #1725 fix this issue for you?
This might be better as another issue but another palce where lack of scrolling is a problem is the Rules Editor where some of the options for keypress action (Depress, Click etc) get hidden if window is too small and the whole thing doesn't fit vertically even on 1080p.
What exactly is the problem? Both the rules display and the rules editor are scrollable.
Ah, I didn't notice that the rule editor is scrollable separately without having to resize the window. I guess this caused confusion for me initially since the way the window open up by default, it seems like that section is not scrollable and that there is nothing below it which might be confusing but yeah, not a major issue if it is scrollable and unrelated to this one.
Given that editing rules is the reason for the editor it makes sense to set up the editing window with enough room. I'll see about doing that.
@pfps Works better for me - but I have left a minor comment in the PR...
@sidevesh When I open up the rule editor (with the most up-to-date Solaar code) the rule editing panel always shows all of the editing controls, with the expanding and contracting as needed. Is this not what you see? This may only happen when running Solaar from this repository.
@pfps no, in my case it opens to the size that you can see in the screenshot I shared and it does not expand or contract, I am on 1.1.4 installed from arch aur though.
There were changes to this part of Solaar since 1.1.4. So clone this repository and run bin/solaar
in it and see what you experience.
Information
uname -srmo
):Linux 5.10.0-17-rt-amd64 x86_64 GNU/Linux
solaar show
:~/.config/solaar/config.yaml
(or~/.config/solaar/config.json
if~/.config/solaar/config.yaml
not present):No obvious error messages!
Describe the bug The minimum vertical size for the main window is too large to be accommodated on a laptop with a 1280x800 screen size and since the "options" on the right hand size are not in a "ScrollArea" it is not possible to reduce the height of the whole dialogue (which might otherwise "activate" a vertical scroll bar to give access to the last few controls) to a point where the "Quit Solaar"/"About Solaar"/"Rule Editor" buttons are visible.
To Reproduce Steps to reproduce the behaviour:
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.