Closed cmeeren closed 4 years ago
It's pretty annoying having this pop up all the time and not disappear just because my MX Master does power saving.
Btw, is this still an issue with the latest git version? There have been so many changes, could you give it a go?
Yes, I still receive a notification each time the device is powered on.
An unprofessional and temporary solution:
Replace
n.show()
with
if(reason != _("powered on")):
n.show()
on line 130 (older version) or 141 (in the current master repo) in file notify.py. For me the file was in /usr/share/solaar/lib/solaar/ui.
Other important notifications such as battery status are still shown.
Thanks, I'll keep that in mind. Is there any chance this could be added as a configuration option in Solaar?
@cmeeren ,
I can try to implement it but do not expect it for any time soon. I am busy these days. Let this ticket open and I will try tackle it.
As always: help wanted
@jrbenito would you be able to point me to where you create the menu add buttons etc so I can add a checkbox to disable the power notifications via pull request?
Re. checkboxes; always the best UI is no UI.
I'm struggling to think of valid uses for positive notifications e.g. 'powered on', 'battery full' etc.
Battery percentage is available when you open the Solaar popup (selecting 'Unifying Receiver' from the dropdown), so in the contrived scenario that someone is waiting til their keyboard battery gets to 100% in order to e.g. close their laptop, then I don't think it's too much to ask that they periodically check there.
The only notifications which should interrupt a user (and all notifications are intrusive) is if an in-use peripheral gets to < 10% power, and action is required from user to fix the situation.
Instead of a checkbox, how about just disabling all non-critical notifications? A related enhancement would be to put the battery percentage or indicator beside the device item in the dropdown.
What about this issue ? Looking forward to this feature.
I second that. There's no reason for me to know that my mouse is turned on. At least there should be a way to turn these off.
This is super annoying.
Feel free to draft a PR with the necessary changes.
This is driving me crazy. Please let's have the enhancement soon.
Patches are welcome.
Notifications were turned off in Solaar due to problems in an old version of Fedora. They are turned on again in the current version of Solaar in this repository. That said, notifications might be too intrusive in some cases. Does anyone have suggestions on which notifications to not show?
Most window mangers can turn off notifications on a per-application basis. In XFCE this is in main menu, Settings, Notifications. Then click on Applications and turn off the switch for Solaar.
Closing because desktop environments should have a way to turn off notifications on a per-application basis. XFCE has this feature so full-featured desktop environments should also.
Notifications were turned off in Solaar due to problems in an old version of Fedora. They are turned on again in the current version of Solaar in this repository. That said, notifications might be too intrusive in some cases. Does anyone have suggestions on which notifications to not show?
As I read the intent of the thread, the conversation clarified that they were looking for a way to filter out certain types of messages vs completely disable them. Some would be more important than others like Low Battery vs. Device returning from power save.
If there is consensus on which notifications are just too much, and should never be shown, then it would be easy to get rid of these. Solaar already makes some notifications low priority - it would be nice if desktop environments could filter on that. If, however, there has to be a flag that determines which notifications to show then that's a much larger implementation burden.
If there is consensus on which notifications are just too much, and should never be shown, then it would be easy to get rid of these. Solaar already makes some notifications low priority - it would be nice if desktop environments could filter on that. If, however, there has to be a flag that determines which notifications to show then that's a much larger implementation burden.
That is a good question, and it Would be nice if the filters were in the desktop environment. I could see them 1) grouping them into types and for those with progressive values like battery power 2) having the ability to set a personal threshold for an alert type. So one person may want to know when a battery level hits below 20% and someone else may want to know at 50%. That said... clearly low priority and the notification is more of an annoyance on device wake ups. It'd be nice just to toggle that alert and I would be happy. But you are writing for a large community not one person. :) So I get it. I will look at the code to see if I can make it "work for me" in the meantime. Thanks for all the work you do on this!
Most people in this issue mentioned the ‘powered on’ notification as annoying.
What is the purpose of this message? I know it is at least triggered if the mouse/keyboard is waked up from the power saving state (for my keyboard this happens often). Are there setups were the meaning is different or have more meaning? (Are there setups that do not power saving?) is the first time it is powered on useful enough for anyone to be notified?
I think, most people will have already a look in Solaar if their device does not power on. So then this message is also not helping because it could of course not tell something is yet disabled. Btw, the fact that your mouse or keyboard is already responding if moved or typed is even quicker way of notifying that it is available. Therefore no formal notification is actually needed.
So my impression is that this ‘powered on’ message can be safely removed without loss of information. At least for mouses and keyboard.
Klap - personally that is the one message I'm looking to get rid of. If there are people that prefer to have it, it would need to be a toggle. When my MX Keyboard and MX Master 3 wake they both throw that notification. Given all the work they have planned with the daemon and UI, I'm just looking to make the hack change mentioned in thread until it changes.
An unprofessional and temporary solution:
Replace
n.show()
with
if(reason != _("powered on")): n.show()
on line 130 (older version) or 141 (in the current master repo) in file notify.py. For me the file was in /usr/share/solaar/lib/solaar/ui.
Other important notifications such as battery status are still shown.
The work around from J-8 is effective.
1) Make the change in the file as specified above 2) Make sure to Quit Solaar (or kill -15 the process if it won't quit) 3) (Re)start solaar to load the change 4) turn off your mouse and or keyboard and turn them back on to test the change. The message will not appear now and does not when the devices "power on" from power save mode.
Closing because desktop environments should have a way to turn off notifications on a per-application basis. XFCE has this feature so full-featured desktop environments should also.
Cinnamon does not have this option built-in, and it's a pretty popular DE (used by Linux Mint for example). The only option that I am aware of is to disable notifications system-wide, which shouldn't be necessary.
I fixed it upgrading Solaar to version 1.0.3 from Solaar git ppa, according to the instructions in this page: https://launchpad.net/~solaar-unifying/+archive/ubuntu/ppa. Everything works fine now.
I have version 1.0.4 installed from github, and I still receive those annoying notifications (using Logitech M590 and K780). The trick given by @J-8 works fine for me, though. In my case I found the notify.py file here: .local/lib/python3.8/site-packages/solaar/ui/notify.py
.
If you're using Dunst as a notification daemon, I've solved this issue by explicitly filtering Solaar notifications. Add this to your dunstrc
file:
[solaar]
appname = "Solaar"
format = ""
One more vote for getting rid of powered on
notification. It's really annoying.
Side note, application is simple enough that a checkbox to disable notifications wouldn't hurt. While some desktop environments allow disabling notifications per application, most don't.
You're probably using an old version. Try installing the latest version from https://github.com/pwr-Solaar/Solaar.
Em ter., 5 de jan. de 2021 às 11:27, Marek Matulka notifications@github.com escreveu:
One more vote for getting rid of powered on notification. It's really annoying.
Side note, application is simple enough that a checkbox to disable notifications wouldn't hurt. While some desktop environments allow disabling notifications per application, most don't.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pwr-Solaar/Solaar/issues/335#issuecomment-754635591, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWDLEMPZYJIMR4MLJP2HNLSYMHVBANCNFSM4C65HERQ .
You're probably using an old version. Try installing the latest version from https://github.com/pwr-Solaar/Solaar. Em ter., 5 de jan. de 2021 às 11:27, Marek Matulka notifications@github.com escreveu: … One more vote for getting rid of powered on notification. It's really annoying. Side note, application is simple enough that a checkbox to disable notifications wouldn't hurt. While some desktop environments allow disabling notifications per application, most don't. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#335 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWDLEMPZYJIMR4MLJP2HNLSYMHVBANCNFSM4C65HERQ .
I've installed one from my distro's repository, running version 1.0.4.
Today, out of the blue, annoying wake up
notifications started to appear again. Checked the version and it's still 1.0.4, so not sure why they suddenly started appearing.
$ rpm -qa | grep solaar
solaar-udev-1.0.4-3.fc33.noarch
solaar-1.0.4-3.fc33.noarch
This is really annoying that every time I move the mouse or start typing, it shows a notification.
+1 on removing power on notifications... these are really annoying (using solaar on lxqt and I haven't found any other way to prevent this other than editing notify.py as suggested in other comments).
EDIT: correction, modifying notify.py did not solve the issue... I'm still getting "powered on" notifications... :(
The issue seems to still exist in version 1.0.6.
It is a design decision in Solaar to report these status changes.
OK, I could disable all notifications from solaar. Now it's fine. There's apparently an option in KDE to filter out certain notifications from an application but this feature seems to be unavailable for solaar.
OK, I could disable all notifications from solaar. Now it's fine.
@j0hannes : How?
@pathob System Settings > Notifications > Application Settings > Solaar
There, you can disable the option "Show popups".
In Ubuntu/GNOME there is a notification section in the system settings GUI. If you're using that kind of distro, it may apply to you.
That was way too easy. Thanks!
The 'powered on' notifications are now suppressed, since #1359. If these did bother you, you do not need to disable all the notifications any more :-)
Is there any way to disable notifications from Solaar? I don't need it to notify me that my keyboard has been turned on or whatever. :)