Issue-159 - Extension - Connection Timeout Unit Tests

huntharo commented 6 months ago

Fixes #159
Fixes a bug where the channels would get spun up before the router connected
Massive improvements to connection error handling for both the router and the contained app
- Not perfect yet
- The Lambda will still exit with panics in cases where it should stay running (e.g. could not connect to router) but return a response to the router indicating that it cannot connect
Brings Rust test coverage from 0% to 92%
Adds test patterns:
- TlsListener for testing TLS setup timeouts (not a full server, but could be with axum)
- Http2 (H2C - http2 over cleartext) axum-based server for simulating the router
- httpmock::MockServer for simulating the contained app

Rust Coverage Before

https://github.com/pwrdrvr/lambda-dispatch/pull/180#issuecomment-2068177335

github-actions[bot] commented 6 months ago

📊 DotNet Code Coverage Report

File	Lines	Lines Hit / Found	Uncovered Lines	Branches
/src/PwrDrvr.LambdaDisp..ension/MetricsRegistry.cs	❌ 0.0%	0 / 21	21	0.0%
/src/PwrDrvr.LambdaDisp..n/HttpReverseRequester.cs	❌ 0.0%	0 / 41	41	0.0%
/src/PwrDrvr.LambdaDispatch.Extension/Function.cs	❌ 0.0%	0 / 462	462	0.0%
/src/PwrDrvr.LambdaDisp..sion/HttpDuplexContent.cs	❌ 0.0%	0 / 23	23	0.0%
/src/PwrDrvr.LambdaDisp..n/HttpReverseRequester.cs	❌ 0.0%	0 / 296	296	0.0%
/src/PwrDrvr.LambdaDisp..tension/LoggerInstance.cs	❌ 0.0%	0 / 17	17	-
/src/PwrDrvr.LambdaDisp..ension/MetricsRegistry.cs	❌ 0.0%	0 / 21	21	-
/src/PwrDrvr.LambdaDisp..ension/MetricsRegistry.cs	❌ 0.0%	0 / 71	71	0.0%
/src/PwrDrvr.LambdaDisp..on/TcpReverseRequester.cs	❌ 0.0%	0 / 194	194	0.0%
/src/PwrDrvr.LambdaDisp..ension/SetupHttpClient.cs	❌ 0.0%	0 / 33	33	0.0%
/src/PwrDrvr.LambdaDispatch.Messages/Waiter.cs	✅ 100.0%	6 / 6	0	-
/src/PwrDrvr.LambdaDispatch.Messages/Waiter.cs	❌ 0.0%	0 / 2	2	-
/src/PwrDrvr.LambdaDisp...Router/LambdaInstance.cs	✅ 100.0%	3 / 3	0	-
/src/PwrDrvr.LambdaDisp..Router/CapacityManager.cs	✅ 100.0%	51 / 51	0	100.0%
/src/PwrDrvr.LambdaDisp..Router/MetricsRegistry.cs	❌ 2.8%	1 / 36	35	0.0%
/src/PwrDrvr.LambdaDispatch.Router/Config.cs	✅ 98.9%	94 / 95	1	97.7%
/src/PwrDrvr.LambdaDisp..lers/ChunkedController.cs	🟡 88.3%	121 / 137	16	91.7%
/src/PwrDrvr.LambdaDisp..lers/DefaultController.cs	✅ 100.0%	5 / 5	0	-
/src/PwrDrvr.LambdaDisp..ollers/ResetController.cs	✅ 100.0%	8 / 8	0	-
/src/PwrDrvr.LambdaDispatch.Router/Dispatcher.cs	🟡 81.6%	248 / 304	56	71.0%
/src/PwrDrvr.LambdaDispatch.Router/Dispatcher.cs	✅ 100.0%	3 / 3	0	-
/src/PwrDrvr.LambdaDisp..dMetrics/MetricsLogger.cs	✅ 93.6%	132 / 141	9	86.7%
/src/PwrDrvr.LambdaDisp..ics/MetricsLoggerDummy.cs	❌ 0.0%	0 / 2	2	-
/src/PwrDrvr.LambdaDisp..h.Router/GetCallbackIP.cs	✅ 100.0%	8 / 8	0	100.0%
/src/PwrDrvr.LambdaDisp..omingRequestMiddleware.cs	✅ 100.0%	21 / 21	0	83.3%
/src/PwrDrvr.LambdaDisp..Router/LambdaArnParser.cs	✅ 94.6%	35 / 37	2	87.5%
/src/PwrDrvr.LambdaDisp..ter/LambdaClientConfig.cs	✅ 100.0%	18 / 18	0	100.0%
/src/PwrDrvr.LambdaDisp..outer/LambdaConnection.cs	❌ 31.1%	95 / 305	210	10.7%
/src/PwrDrvr.LambdaDisp...Router/LambdaInstance.cs	🟡 59.9%	239 / 399	160	47.5%
/src/PwrDrvr.LambdaDisp../LambdaInstanceManager.cs	✅ 100.0%	4 / 4	0	-
/src/PwrDrvr.LambdaDisp../LambdaInstanceManager.cs	❌ 35.1%	152 / 433	281	64.3%
/src/PwrDrvr.LambdaDisp../LeastOutstandingQueue.cs	🟡 66.0%	142 / 215	73	64.6%
/src/PwrDrvr.LambdaDisp...Router/LoggerInstance.cs	✅ 100.0%	18 / 18	0	-
/src/PwrDrvr.LambdaDisp..Router/MetricsRegistry.cs	❌ 47.6%	10 / 21	11	-
/src/PwrDrvr.LambdaDisp..Router/MetadataService.cs	🟡 84.4%	54 / 64	10	67.6%
/src/PwrDrvr.LambdaDisp..Router/MetricsRegistry.cs	✅ 91.2%	124 / 136	12	-
/src/PwrDrvr.LambdaDisp..Router/MetricsRegistry.cs	❌ 0.0%	0 / 31	31	-
/src/PwrDrvr.LambdaDisp...Router/PendingRequest.cs	✅ 90.0%	45 / 50	5	66.7%
/src/PwrDrvr.LambdaDispatch.Router/Pool.cs	✅ 100.0%	7 / 7	0	-
/src/PwrDrvr.LambdaDispatch.Router/PoolManager.cs	🟡 89.4%	59 / 66	7	78.6%
/src/PwrDrvr.LambdaDispatch.Router/PoolOptions.cs	✅ 100.0%	9 / 9	0	100.0%
/src/PwrDrvr.LambdaDispatch.Router/Program.cs	❌ 0.0%	0 / 157	157	0.0%
/src/PwrDrvr.LambdaDisp..binLambdaInstanceQueue.cs	✅ 90.6%	29 / 32	3	91.7%
/src/PwrDrvr.LambdaDisp..inLambdaInstanceQueue2.cs	✅ 95.3%	61 / 64	3	100.0%
/src/PwrDrvr.LambdaDisp...Router/ShutdownSignal.cs	❌ 0.0%	0 / 1	1	-
/src/PwrDrvr.LambdaDispatch.Router/Startup.cs	❌ 0.0%	0 / 47	47	0.0%
/src/PwrDrvr.LambdaDispatch.Router/TokenBucket.cs	🟡 66.7%	12 / 18	6	100.0%
/src/PwrDrvr.LambdaDisp...Router/LambdaInstance.cs	✅ 100.0%	3 / 3	0	-
/src/PwrDrvr.LambdaDisp..Router/WeightedAverage.cs	✅ 91.7%	44 / 48	4	100.0%
/src/PwrDrvr.LambdaDisp..Router/TrailingAverage.cs	✅ 100.0%	36 / 36	0	100.0%
Overall	❌ 45.0%	1897 / 4220	2323	44.7%

github-actions[bot] commented 6 months ago

📊 Rust Code Coverage Report

File	Lines	Lines Hit / Found	Uncovered Lines	Branches
/extension/src/app_request.rs	✅ 99.0%	1038 / 1049	11	-
/extension/src/app_start.rs	🟡 85.4%	229 / 268	39	-
/extension/src/cert.rs	🟡 88.3%	188 / 213	25	-
/extension/src/connect_to_app.rs	🟡 88.9%	255 / 287	32	-
/extension/src/connect_to_router.rs	✅ 92.3%	298 / 323	25	-
/extension/src/counter_drop.rs	✅ 100.0%	23 / 23	0	-
/extension/src/endpoint.rs	✅ 91.0%	121 / 133	12	-
/extension/src/lambda_request.rs	✅ 96.6%	86 / 89	3	-
/extension/src/lambda_service.rs	✅ 94.3%	766 / 812	46	-
/extension/src/main.rs	🟡 83.7%	251 / 300	49	-
/extension/src/messages.rs	✅ 100.0%	95 / 95	0	-
/extension/src/options.rs	✅ 100.0%	154 / 154	0	-
/extension/src/ping.rs	🟡 89.9%	1003 / 1116	113	-
/extension/src/router_channel.rs	✅ 92.8%	1192 / 1285	93	-
/extension/src/test_http2_server.rs	✅ 96.2%	76 / 79	3	-
/extension/src/threads.rs	🟡 71.4%	5 / 7	2	-
/extension/src/time.rs	✅ 100.0%	6 / 6	0	-
Overall	✅ 92.7%	5786 / 6239	453	-

pwrdrvr / lambda-dispatch

Issue-159 - Extension - Connection Timeout Unit Tests #176

Rust Coverage Before

📊 DotNet Code Coverage Report

📊 Rust Code Coverage Report