search

pwsafe / pwsafe

Password Safe - popular secure and convenient password manager
https://pwsafe.org
Other
721 stars 148 forks source link

[Wayland] Unlock Password dialog does not appear #1322

Open nobugshere opened 2 months ago

nobugshere commented 2 months ago

Using local builds from the current master:

  1. Open a file, then lock it. The window minimizes.
  2. Click the icon and an empty main window appears but the Unlock Password Database dialog does not.
  3. Using File|Unlock or Ctrl-I brings-up the dialog and you can proceed as normal.

I've only seen this happen on Wayland based desktops: Fedora 40 ARM64 VMware, KDE/Wayland, gcc 14.1.1, wx 3.2.4, GTK 3.24.42 Ubuntu 24.04 ARM64 VMware, Gnome/Wayland, gcc 13.2.0, wx 3.2.4, GTK 3.24.41

Specifically, it works as expected on these platforms: macOS M1Max Sonoma 14.5, Xcode 15.4, wx 3.2.4 and 3.2.5 (local debug build) Fedora 40 ARM64 VMware, Xfce/X11, gcc 14.1.1, wx 3.2.4, GTK 3.24.42

igor2x commented 2 months ago

This is an old issue I have never reported, but I know it has been present for a long time. For example I can reproduce a problem in Password Safe v1.18.2 using flatpak. But I am quite sure this problem existed even before. I used to think this is just one of the feature not yet implemented on Linux, because there are many thinks not working (auto-type, virtual keyboard... but there are all Wayland specific).

Additionally it looks like password database was closed down or that somehow program crashed, because there is this automatic minimize on Lock.

image

I used to think this was some issue that appears time to me (but it was auto-lock after time expiration) and I used to think the program has somehow closed down the database (because no groups/entries are visible) and when I clicked on Open and select a database it returned error the database is already opened. This all looks like weird behaviour and strange UX, but then somehow I have found out the solution was File | Unlock.

I have also lost some passwords, because I have unchecked auto-password saving and when this issue appeared I closed down the program and there used to be strange Yes/No questions and easily miss correct option.

I think fixing problems like this would massively improve UX. On Windows when user clicks on Lock button program minimizes automatically, but when clicked on program again to restore from minimize Unlock dialog is automatically displayed.

nobugshere commented 2 months ago

Hi @igor2x, I'm not sure I understand what you are describing, but it sounds like something I encountered when I had the System try icon/menu enabled on Wayland distros. (Manage | Options | System) (Despite the red warning message that it doesn't appear to be supported. :) ) Either Wayland doesn't support the concept, or wxWidgets hasn't been adapted yet. When the window is closed, the program kept running but seemed to loose all connection to the window manager, so clicking the icon tried to start a new instance. I had to track-down the old pwsafe process and kill it. Leaving the system tray option off works as expected.

Edit: Just to be clear, I can reproduce this issue as described with the system tray disabled, but only on Wayland platforms.

igor2x commented 2 months ago

@nobugshere, I am not sure we are facing the same issue, I have opened a new issue 1339 that is Wayland specific bug in Password Safe.