search

pxb1988 / dex2jar

Tools to work with android .dex and java .class files
Apache License 2.0
12.06k stars 2.09k forks source link

Add gradle 7 support by fixing deprecated notations in build.gradle #542

Closed hidenorly closed 10 months ago

hidenorly commented 2 years ago

This pull request is intended 1) to migrate from deprecated notation (compile and testCompile) to recommended notation 2) to migrate deprecated plug-ins 3) to update grade from 6.9.1 to 7.4.2 (to support recent OpenJDK)

Background is that For 1), please see https://docs.gradle.org/current/userguide/upgrading_version_6.html#sec:configuration_removal and gradle 7 already removed the support. For 2), please note that maven and java plug-ins are also deprecated. For 3), gradle 6.9.1 doesn't support recent OpenJDK. See https://docs.gradle.org/current/userguide/compatibility.html

Confirmed environment: Gradle 7.4.2 Build time: 2022-03-31 15:25:29 UTC Revision: 540473b8118064efcc264694cbcaa4b677f61041

Kotlin: 1.5.31 Groovy: 3.0.9 Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 JVM: 18.0.1.1 (Homebrew 18.0.1.1+0) OS: Mac OS X 12.4 aarch64

On this environment with pull request, dex2jar is successfully built.

ThexXTURBOXx commented 2 years ago

See #486

hidenorly commented 2 years ago

See #486

Since #486 is too big PR, I suggest to merge this as the gradle 7 support separately.

ThexXTURBOXx commented 2 years ago

486 is not meant to merge anyways, but rather to cherry-pick.

It was just a friendly reminder that it was already done :)

ThexXTURBOXx commented 10 months ago

Closing this in favor of #486