search

pxp-lang / pxp

A suite of high-performance tools for PHP developers – includes a code formatter, static analyser, language server and superset language.
https://pxplang.org
Other
784 stars 0 forks source link

Limit diagnostics to one per span / position #77

Open ryangjchandler opened 2 months ago

ryangjchandler commented 2 months ago

The diagnostics that get generated in the parser stack up right now, so if you write some bad code, we end up dumping a bunch of diagnostics on you.

This is less than ideal and I personally think there should only be one diagnostic at a time. Once you've fixed one, you'll see the next one and can progressively fix the problem.

At the same time, we should probably make sure our diagnostics actually make sense too.

zeina1i commented 1 month ago

Hey @ryangjchandler Can I take this issue?

ryangjchandler commented 1 month ago

@zeina1i Absolutely, feel free to tackle this one and open a PR!