Various small fixes - Githubissues

pxslip / laravel-scout-solr

A Laravel Scout Engine for Apache Solr

MIT License

19 stars 14 forks source link

Closed krtek4 closed 5 years ago

krtek4 commented 5 years ago

Hi,

Here's a small PR with various small fixed regaring PHPdoc and typehinting.

I also fixed something when building the filter query where the $query variable didn't exist. I assume you meant $item.

pxslip commented 5 years ago

Thanks for the fixes!

krtek4 commented 5 years ago

One of them introduced an error, I'll send a patch later.

Thanks for the merge

pxslip commented 5 years ago

Just makes writing a batch of tests even more of a priority, I'm going to try to tackle that in the coming weeks.

krtek4 commented 5 years ago

If you put the base in place I might be able to contribute some tests :)