search

py-cov-action / python-coverage-comment-action

Publish coverage report as PR comment, and create a coverage badge & dashboard to display on the Readme for Python projects, all inside GitHub without third party servers
https://github.com/marketplace/actions/python-coverage-comment
MIT License
84 stars 32 forks source link

Images don't display in email notifications from Gmail #371

Open ewjoachim opened 9 months ago

ewjoachim commented 9 months ago

I wonder if there's something we can do so that notification emails are more readable. (this is from Gmail btw)

image

ewjoachim commented 9 months ago

Works on other clients. image

mbrisson-ivadolabs commented 7 months ago

I see the same issue using corporate gmail and Apple Mail

ewjoachim commented 7 months ago

Hm, so I think it's because svg is not supported in many email clients. Apparently, a simple change could be to switch from img.shields.io to raster.shields.io [edit] or changing .svg to .png[/]

Funnily enough, this could actually decrease the bandwith usage, as apparently on a few badges I've tried, the png is slightly smaller than the svg.

ewjoachim commented 6 months ago

Ok, apparently the .png provided by shields.io are the exact size of the badge is supposed to appear, so on screens with high pixel density the badge is very ugly. Until we find a way to fix this, I think I prefer the badge to appear right in github and not in gmail than ugly everywhere.

ewjoachim commented 5 months ago

I did some tests in #414 and nothing satisfactory was found. This stays an open problem. Anyone with an idea, feel free.

ewjoachim commented 5 months ago

Hm, alternative idea: embed the SVG. Does this work ?