Closed ewjoachim closed 1 week ago
Admin commands cheatsheet:
/e2e
(in approved PR review body): Trigger end-to-end tests on external contributions/invite
(in comment): Invite the author & admins to the end-to-end private repoThe good news is that the images appear in the gmail notification. The bad news is that it's a pixel garbage mess, barely readable (on a retina display).
Of course, the github version is a mess too
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
coverage_comment
badge.py
template.py
Project Total
This report was generated by python-coverage-comment-action
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
subdir/end_to_end_tests_repo
__init__.py
Project Total
This report was generated by python-coverage-comment-action
<img src="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png">
This would be with srtset 2x
:
<img srcset="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png 2x" src="https://img.shields.io/badge/Coverage%20evolution-83%25%20%3E%2091%25-brightgreen.png">
(it doesn't display)
Ah ? https://github.blog/changelog/2022-05-19-specify-theme-context-for-images-in-markdown-beta/
Let's investigate!
<picture>
<source media="(min-resolution: 2dppx)" srcset="https://webkit.org/demos/srcset/image-2x.png">
<img src="https://webkit.org/demos/srcset/image-1x.png">
</picture>
Doesn't work for me: the image loads when I open the PR, but when I reload, it disappears.
Closing for now.
Closes #371