py-econometrics / pyfixest

Fast High-Dimensional Fixed Effects Regression in Python following fixest-syntax
https://py-econometrics.github.io/pyfixest/
MIT License
172 stars 35 forks source link

Refactoring to pass linting rules #307

Closed s3alfisc closed 9 months ago

s3alfisc commented 9 months ago

@NKeleher has suggested the following linting rules:

select = [
  "F", # Pyflakes
  "E", # pycodestyle errors
  "W", # pycodestyle warnings
  "I", # isort
  "D", # flake8-docstrings
  "UP", # pyupgrade
  "SIM", # flake8-simplify
  "TRY", # tryceratops
]

and suggests to break up the refactoring into module specific PRs which we merge into fix-linting-errors step-by-step.

Then when all of these are linted, we merge fix-linting-errors to the master branch.

NKeleher commented 9 months ago

Perfect! Thanks @s3alfisc. I've started working these items.

s3alfisc commented 9 months ago

As I have merged all changes to master with 5408f25, this can be closed! Thanks for all your work on this @NKeleher 🎉