search

py-econometrics / pyfixest

Fast High-Dimensional Fixed Effects Regression in Python following fixest-syntax
https://py-econometrics.github.io/pyfixest/
MIT License
152 stars 28 forks source link

Add codecov config yml #401

Closed juanitorduz closed 5 months ago

juanitorduz commented 5 months ago

This is just an experiment to see if it fixes the codecov errors (I am not an expert but I took this config model from another project (https://github.com/pymc-labs/pymc-marketing/blob/main/codecov.yml) , lets see)

juanitorduz commented 5 months ago

This PR 🤦 does not trigger the coverage check ... you can decide if merge this one or not in order to experiment :)

juanitorduz commented 5 months ago

From the report it is always comparing the changes with an old commit https://github.com/s3alfisc/pyfixest/commit/35b47e97926438cfdd91de66d3bc224d0704d06a

Maybe this yml file does help. I do not know why is not using the latest commit in master

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.90%. Comparing base (35b47e9) to head (39e3373). Report is 55 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #401 +/- ## ========================================== - Coverage 85.79% 81.90% -3.89% ========================================== Files 38 53 +15 Lines 3421 4178 +757 ========================================== + Hits 2935 3422 +487 - Misses 486 756 +270 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

s3alfisc commented 5 months ago

This PR 🤦 does not trigger the coverage check ... you can decide if merge this one or not in order to experiment :)

I'll merge it and then we'll see what happens =)

juanitorduz commented 5 months ago

ok @s3alfisc I think I added the features I had in mind this week hehe. I will let you work on MyPy so that you don't get PR merge conflicts, as I expect that to be a big piece of work. Let me know if you get stuck ;)

As I plan to use this library, I will now start looking into the docs and the code and create issues if necessary just to have a record of things that might be improved from a user perspective :D

s3alfisc commented 5 months ago

ok @s3alfisc I think I added the features I had in mind this week hehe

Thanks for all your contributions in the last days - they are really much appreciated! I looking forward to your feedback on both docs and codebase improvements, and any potential new features you might be interested in =)

Btw I've started on the MyPy task, and I'm down to "only" 144 errors ... =D