search

py-econometrics / pyfixest

Fast High-Dimensional Fixed Effects Regression in Python following fixest-syntax
https://py-econometrics.github.io/pyfixest/pyfixest.html
MIT License
119 stars 27 forks source link

empty iplot + populate `__version__` in root `__init__.py` #404

Closed apoorvalal closed 2 months ago

apoorvalal commented 2 months ago

Hi folks,

quick bug report I noticed when running an event study:

image

this is on the most up-to-date version of pf on pypi. Haven't had a chance to look at the internals that might be causing this; but I suspect it is something annoying like the coefficient matrix having unexpected names or sth.

A separate (small) issue is that I often like to check __version__ from packages I've imported and most packages set this in the root __init__.py file (long discussion on where to put it here); this currently does not work for pyfixest.

s3alfisc commented 2 months ago

Hi @apoorvalal, thanks for reporting! This is a bug that I introduced with 0.18.0 (I believe), when I significantly reworked the string matching logic that detects the variables interacted via the "i()" operator. #405 provides a fix, I'll release to pypi once I have found the error that leads to #367.

I'll add the __version__ tag - this should be super useful, in particular given the frequency of new versions of pyfixest at the moment. Maybe this will also allow watermark to pick up pyfixest's version?

s3alfisc commented 2 months ago

@all-contributors please add @apoorvalal for bug.

allcontributors[bot] commented 2 months ago

@s3alfisc

I've put up a pull request to add @apoorvalal! :tada:

apoorvalal commented 2 months ago

nice! seems like you need to add watermark and autoreload as a dependency though; the doc notebook currently has an import error in the first cell

s3alfisc commented 2 months ago

Thanks! A fix is on the way =)