search

py-econometrics / pyfixest

Fast High-Dimensional Fixed Effects Regression in Python following fixest-syntax
https://py-econometrics.github.io/pyfixest/pyfixest.html
MIT License
117 stars 27 forks source link

Update quickstart notebook with corrected typos and WLS #522

Open prteek opened 1 week ago

prteek commented 1 week ago

The quickstart guide in the documentation has been updated. New imports, execution code and guide for WLS have been added for better illustration of the library usage.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

prteek commented 1 week ago

I have created this PR for your review @s3alfisc I mean to also add plot at the end comparing prediction and prediction intervals of OLS and WLS and wanted to check if there's a way these can be generated using the library or will need to be manually computed ?

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

see 28 files with indirect coverage changes

s3alfisc commented 1 week ago

Thank you @prteek! I'm time constraint tonight but will take a closer look tomorrow evening / Saturday morning. Did you manage to build the docs locally? For some reason, the github action seems to fail :/

prteek commented 1 week ago

Hi ! I get the same error in rendering step locally (build step works fine). Seems to be related to https://github.com/quarto-dev/quarto-cli/issues/9255 but I can't quite figure it out for my lack of experience with Quarto.

prteek commented 1 week ago

@s3alfisc able to build and render docs now. Still not clear on why this happened but apparently something in notebook metadata goes wrong when adding a markdown cell using PyCharm. I've re written those cells in Jupyter lab and it seems to fix this issue.

prteek commented 5 days ago

@s3alfisc this is largely done. If you could please review and approve the workflow that'd be awesome. Also wanted to understand if there is a way in library to get prediction intervals easily ?

s3alfisc commented 5 days ago

Hi @prteek , please apologize that I've made you wait on a review! It's simply been very busy days for me. I added quite a few comments in the notebook. I hope that all comments are clear - if not, please ask; and if you disagree, complain! =) Best, Alex

prteek commented 3 days ago

Hi @prteek , please apologize that I've made you wait on a review! It's simply been very busy days for me. I added quite a few comments in the notebook. I hope that all comments are clear - if not, please ask; and if you disagree, complain! =) Best, Alex

No worries and thanks for the tips there ;-) . I'll give it another go just need a couple more days before I can start.