search

py-econometrics / pyfixest

Fast High-Dimensional Fixed Effects Regression in Python following fixest-syntax
https://py-econometrics.github.io/pyfixest/
MIT License
176 stars 35 forks source link

feols` and `fepois` check input types for literal string arguments #691

Open marcandre259 opened 2 weeks ago

marcandre259 commented 2 weeks ago 
          Another thing I oversaw in my initial review - `feols` and `fepois` check input types in https://github.com/py-econometrics/pyfixest/blob/a3ed27aefef01e80ade7ebf117d5999239bbb62b/pyfixest/estimation/estimation.py#L617

Maybe we could update them to use the Literal validation function whenever relevant?

Originally posted by @s3alfisc in https://github.com/py-econometrics/pyfixest/issues/680#issuecomment-2448462631

s3alfisc commented 2 weeks ago

Yes, would be nice to do it via validate_literals!

marcandre259 commented 2 weeks ago

Super, I'll look into it :)