Closed leostimpfle closed 2 weeks ago
Some of pyfixest's custom error classes in pyfixest.errors duplicate Python's built-in exceptions, for example NotImplementedError:
pyfixest
pyfixest.errors
NotImplementedError
https://github.com/py-econometrics/pyfixest/blob/f1c8a59e86adead07df879d928c588a58206f538/pyfixest/errors/__init__.py#L41
For consistency, we should always use Python's built-in exceptions and remove duplicate errors in pyfixest.errors, for example here:
https://github.com/py-econometrics/pyfixest/blob/f1c8a59e86adead07df879d928c588a58206f538/pyfixest/estimation/fepois_.py#L10
A list of Python's built-in errors is available here.
Some of
pyfixest's custom error classes inpyfixest.errorsduplicate Python's built-in exceptions, for exampleNotImplementedError:https://github.com/py-econometrics/pyfixest/blob/f1c8a59e86adead07df879d928c588a58206f538/pyfixest/errors/__init__.py#L41
For consistency, we should always use Python's built-in exceptions and remove duplicate errors in
pyfixest.errors, for example here:https://github.com/py-econometrics/pyfixest/blob/f1c8a59e86adead07df879d928c588a58206f538/pyfixest/estimation/fepois_.py#L10
A list of Python's built-in errors is available here.