ItsDrike
commented
9 months ago The biggest reason as to why this project only supports pyright is that mypy often takes significantly longer than pyright to implement any new typing features.
In the time of adding pyright to the project, mypy still didn't even have support for typing.Self (even though pyright already had it for about a year by then), which made mypy a bad choice for us at the time.
Since then, I haven't really been keeping up to date with mypy's development, and it's entirely possible that they've got better at keeping up though. However if that's not the case, I'm not sure I'd like to bring it in, as it could potentially prevent us from being able to use some nice new typing features.
That said, if things are better now, I'm not necessarily against adding mypy alongside with pyright.
I don't think we would make any use of mypyc though, and I'd like to have a better reason to make this change than just:
would mean I don't get type errors in my project just because I don't use pyright
Contributors are expected to conform to the project's style guidelines, and to set up their development environment for the project they're working on accordingly to those guidelines, regardless of what they prefer.
(Hint: You don't need to have pyright in your editor if you really don't want to, just make sure to run pre-commit to ensure that pyright will pass, and not to introduce any mypy-specific stuff. Although adding pyright to your editor would probably result in a better experience. Most editors should be configurable in a way that lets you disable/enable various linters/type-checkers on a per-project basis, so it doesn't have to change your workflow on other projects.)
Even if mypy support would be added though, it won't mean removal of pyright, we would just be running both, so you'll probably want to set up pyright for mcstatus anyway.
I would like to ask all other contributors reading this to give their opinion on adding mypy, either by commenting, or at least by adding a :+1: or :-1: reaction to the issue, as it is a fairly significant change, and makes mypy knowledge yet another pre-requisite, alongside pyright and all of our other linters.
PerchunPak
kevinkjt2000
Officially supporting type checking with mypy as well would mean I don't get type errors in my project just because I don't use pyright and opens the door to using mypyc to compile the project into a C extension, which in some cases can make things run faster.