Closed ItsDrike closed 5 months ago
Note: I've updated the branch protection rules. Actually, I moved us to the new branch rulesets instead of the classical protection rules, they provide a bit more options and are just nicer to work with. The ruleset matches our original rules exactly, except for the required workflows, which will now expect the new workflows.
Note 2: Since new workflow names are required, all PRs will need to rebase/merge latest master, to get those workflows to run.
This PR introduces various changes to the CI workflows in this repository.
Note: Once merged, it will be necessary to update the branch proection rules.
Changes:
GITHUB_OUTPUT
env var, instead of::set-output
in stdout)SebastiaanZ/github-status-embed-for-discord
action (the action picks these up by default, no need to set them explicitly)github
output format forruff check
, which provides a lot nicer and easier to read formatting of the found issues, suited specifically for github workflows (uses some specific formatting options that github workflows offer to get nice colors, etc.).tests-done
job as a part of thetox-test
workflow, which will trigger once all of the matrix test jobs ended, reporting the final status (fails if any of the test jobs failed). This is useful as we can specify it in the branch protection rules, instead of specifying all of the individual tox-test jobs in the matrix, which would require updating these rules every time the required python versions/platforms change.(This PR is inspired by https://github.com/py-mine/mcproto/pull/300)