CLI: Bedrock support and misc improvements

[katrinafyi]

• Support bedrock servers in CLI, by some simple logic to print additional Java information if available.
• Add ping() method to BedrockServer (via status().latency)
• Add kind() abstract method to return a string representation of the server kind.
• Print "Java"/"Bedrock" in CLI outputs.
• Fix #846 by setting default function to status.
• Print MOTDs using terminal ANSI codes in status and query, assuming this input is meant for humans.
• Print error messages to stderr.
• Set program exit codes to indicate success/failure.
• Formatting tweaks: print bare float in ping and omit trailing space in status if no player sample.
• Quash top-level exceptions into single line, usually due to socket timeout. Maybe this should be limited to timeout/DNS failures? Or configurable via flag?
• There is also a workaround for #850, but that should be addressed directly.

Do you also want tests for the CLI? It would serve as a good end-to-end test case.

Edit: fixes #301.

[katrinafyi]

Linting should be fixed. It would be nice to document how to run these checks (and/or the GH action could print the violations). (I did it by uncommitting my changes, then poetry run pre-commit, then re-committing the changes. I'm sure this isn't optimal.)

[PerchunPak]

Linting should be fixed. It would be nice to document how to run these checks (and/or the GH action could print the violations). (I did it by uncommitting my changes, then poetry run pre-commit, then re-committing the changes. I'm sure this isn't optimal.)

Yeah, https://mcstatus.readthedocs.io/en/stable/pages/contributing/ can be significantly improved

[katrinafyi]

Ah, I didn't even find that oops! I thought that would be end-user docs, and I was looking in the readme and CONTRIBUTING.md (which doesn't exist). I now see it is also in-repo at docs/pages/contributing.rst

[katrinafyi]

Is there a good server for testing query? demo.mcstatus.io seems to be failing. Edit: filed #857.

[PerchunPak]

Is there a good server for testing query? demo.mcstatus.io seems to be failing. Edit: filed #857.

I only use play.lbsg.net for testing bedrock in StatusMC, so you probably should just use docker run -d -it -p 25565:25565 -e EULA=TRUE -e ENABLE_QUERY=true itzg/minecraft-server

[ItsDrike]

Hey, I'm a bit busy now, so I'll leave the convo resolution up to you guys for now, but once you'll approve it, please request a review from me before merging @PerchunPak

[DAMcraft]

wow, this is really great, except for one issue tool.poetry.scripts in the pyproject.toml points to mcstatus.__main__:main, which now requires an argument this leads to the following: python3 -m mcstatus works like intended mcstatus (over the binary) throws an error, because it tries running the main() function without any arguments

i'd simply add a run() function so currently it says:

if __name__ == "__main__":
    sys.exit(main(sys.argv[1:]))

which i would change to

def run() -> int:
    return main(sys.argv[1:])

if __name__ == "__main__":
    sys.exit(main(sys.argv[1:]))

then you'd simply need to change it to mcstatus.__main__:run in the pyproject.toml and that's it!

[PerchunPak]

Or even better I think

def run() -> None:
    sys.exit(main(sys.argv[1:]))

if __name__ == "__main__":
    run()

[DAMcraft]

Or even better I think

def run() -> None:
    sys.exit(main(sys.argv[1:]))

if __name__ == "__main__":
    run()

i don't know if that's the best solution, considering that the tool.poetry.scripts already gets wrapped in a sys.exit

so this would basically lead to the code of

def run() -> None:
    sys.exit(main(sys.argv[1:]))
sys.exit(run())

or simplified:

sys.exit(sys.exit(main(sys.argv[1:])))

which is honestly quite a mess

but honestly i don't know

[PerchunPak]

Didn't know that, then yes, your solution is better

[DAMcraft]

okay this is the best solution i think, thanks!

[kevinkjt2000]

@ItsDrike The green button is tempting me like the one ring. The precious. I wants it.

[katrinafyi]

thank you for your feedback, I have made changes in response to the addressable points.

[ItsDrike]

Thanks!