py-pdf / fpdf2

Simple PDF generation for Python
https://py-pdf.github.io/fpdf2/
GNU Lesser General Public License v3.0
1.13k stars 253 forks source link

print headers on page break #1152

Closed shoaib-moeen closed 5 months ago

Lucas-C commented 6 months ago

Hi @shoaib-moeen

Note that the table headers already split over page breaks:

Could you please provide a minimal code snippet reproducing the problem that you are facing? 🙂

shoaib-moeen commented 6 months ago

Hi @Lucas-C ,

Problem was when a single row breaks the page due to very long text it didn't print headers on the next page. It is related to issue #1142 . For now my usage was really limited to the headers not being displayed.

Lucas-C commented 6 months ago

Problem was when a single row breaks the page due to very long text it didn't print headers on the next page. It is related to issue #1142 . For now my usage was really limited to the headers not being displayed.

Alright. Could you maybe provide some minimal code reproducing your problem? 🙂 cf. https://stackoverflow.com/help/minimal-reproducible-example Such minimal code will be need to craft a unit test, which is mandatory as part of Pull Requests altering fpdf2 source code.

Lucas-C commented 6 months ago

Hi!

Just a quick update about this: @shoaib-moeen are you still willing to work on this feature? If you don't, or do not have time for this anymore, that is totally fine! 🙂 If so we will just close this PR.

Also, if you need feedback or help on this PR, please tell us! 🙂

Lucas-C commented 5 months ago

Closing this PR for now. Please comment there if you want to reopen it.