Closed carlhiggs closed 6 months ago
@allcontributors please add @carlhiggs for code
@gmischler
I've put up a pull request to add @carlhiggs! :tada:
I've just addressed latest round of review requests: more accurately referring to when 'wrapmode is "CHAR"' in one specific test's self-descriptive text (and updated test pdfs used to validate this to have the changed text too), and externalising duplicate text to a shared python file containing elements now used in both template and flextemplate tests of the optional wrapmode functionality. Black and pylint were run using CLI, and through pre-commit hook. The pylint warnings that remained did not relate to my tests or modifications, but to various "pylint.extensions" that apparently were impossible to load ("bad_plugin-value"?). I believe that is not an issue with this pull request, but something upstream. If this passes checks, do you think this could be could to merge @gmischler ?
Thanks for the contribution, @carlhiggs ! Merging now.
Fixes #1159
Checklist:
[x] The GitHub pipeline is OK (green), meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.[x] A unit test is covering the code added / modified by this PR
[x] This PR is ready to be merged
[x] In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folder[x] A mention of the change is present in
CHANGELOG.md
In the flextemplate test for the wrapmode functionality, I tested a range of possibilities described in text of each template element. The first three elements test that the new code doesn't do anything strange to existing funcitonality; the last one specifically tests that wrapmode='CHAR' wraps accordingly:
The output of the above looks correct to me:
I ran black and checked pylint in vscode; I believe the changes I made should be all fine for these requirements.
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.