Closed andersonhc closed 3 weeks ago
Attention: Patch coverage is 99.46524%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 93.29%. Comparing base (
2b866d8
) to head (acb6af1
). Report is 15 commits behind head on master.:exclamation: Current head acb6af1 differs from pull request most recent head 45074fd
Please upload reports for the commit 45074fd to get more accurate results.
Files | Patch % | Lines |
---|---|---|
fpdf/unicode_script.py | 99.43% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As pointed in #1187, if the text has different languages, harfbuzz will auto-detect and shape using the first script found.
This change includes the Unicode Scripts table into
fpdf2
and breaks the input string into different fragments that are shaped individually if multiple scripts are found.Having fragments being "script aware" will also be useful in the future to implement automatic text wrapping.
Checklist:
[ ] The GitHub pipeline is OK (green), meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.[ ] A unit test is covering the code added / modified by this PR
[ ] This PR is ready to be merged
[ ] In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folder[ ] A mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.