py-pdf / fpdf2

Simple PDF generation for Python
https://py-pdf.github.io/fpdf2/
GNU Lesser General Public License v3.0
1.13k stars 253 forks source link

Clarify `FPDF.add_font()`'s `style` parameter accepted values #1263

Closed jhenriquelc closed 2 months ago

jhenriquelc commented 2 months ago

Changes:

In FPDF.add_font(), a line of documentation about the accepted values of the style parameter is being clarified to explicitly mention the empty string case and infer that "BI" is an accepted value.

Motives:

I suspect this is the cause for a misimplementation in typeshed's typing stubs, which I have opened a PR there to fix.

Sorry for this small PR, but I felt like it was appropriate. I'm looking forward to doing more (and bigger) docs clarifications if they're welcomed.

Thank you for working on this amazing project, maintainers!

Checklist:

License consent:

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

Lucas-C commented 2 months ago

Thank you for your contribution @jhenriquelc 👍 I'm going to merge this PR now.

@allcontributors please add @jhenriquelc for documentation

allcontributors[bot] commented 2 months ago

@Lucas-C

I've put up a pull request to add @jhenriquelc! :tada: