Closed Lucas-C closed 1 year ago
@MartinThoma: I think you added a dependency to fpdf2
in https://github.com/py-pdf/pdfly/blob/main/pdfly/x2pdf.py#L6
But this dependency was not declared in https://github.com/py-pdf/pdfly/blob/main/pyproject.toml#L31
Which is why the unit tests are currently failing in the GitHub Actions pipeline:
Run pytest -vv
ImportError while loading conftest '/home/runner/work/pdfly/pdfly/tests/conftest.py'.
tests/conftest.py:6: in <module>
from pdfly.cli import entry_point
pdfly/cli.py:19: in <module>
import pdfly.x2pdf
pdfly/x2pdf.py:6: in <module>
from fpdf import FPDF
E ModuleNotFoundError: No module named 'fpdf'
If you agree, I can add fpdf2
to pdfly
dependencies as part of this PR
@Lucas-C Thank you for the many improvements :pray:
The PR looks awesome :tada:
One last question before we merge it: Where do the images come from?
Very nice! Thank you :pray:
Thank you!
Now I'll have to fix those xfail-
ing tests... 😅
We could also open issues with the hacktoberfest
tag in order to invite contributors this month:
https://hacktoberfest.com/
I like the idea of inviting new contributors :-) I would need to check what is required by us if we do that. I have no idea.
I like the idea of inviting new contributors :-) I would need to check what is required by us if we do that. I have no idea.
I added a few issues with the hacktoberfest
tag: https://github.com/py-pdf/pdfly/labels/hacktoberfest
I introduced the unit tests I originally developped in https://github.com/py-pdf/pypdf/pull/2170
I also added a
pytest -vv
execution as part of the GitHub Actions pipeline