py-pdf / pdfly

CLI tool to extract (meta)data from PDF and manipulate PDF files
BSD 3-Clause "New" or "Revised" License
109 stars 18 forks source link

Add a warning on missing pages in pdfly cat #33

Closed Lucas-C closed 1 month ago

Lucas-C commented 1 year ago

We want to produce a warning (on stderr) when a user attemps to use pdfly cat to extract a range of pages that is outside the number of pages of the PDF document processed.

We already have a unit test regarding this, so this feature could considered DONE when this unit test will pass: https://github.com/py-pdf/pdfly/blob/main/tests/test_extract_images.py#L20

pavankalyan767 commented 1 year ago

hello i would like to work on this issue can you please assign it to me

Lucas-C commented 1 year ago

hello i would like to work on this issue can you please assign it to me

Great! Sure, I just did so 🙂

Do you plan to work on this as part of https://hacktoberfest.com?

Also please tell us if you stop working on this, so that we can unassign this issue.

pavankalyan767 commented 1 year ago

Thank you for assigning me this issue and yes i want to work on this as a part of https://hacktoberfest.com

Lucas-C commented 11 months ago

Hi @pavankalyan224847

Are you still planning to work on this, or can we unassign you?

pavankalyan767 commented 11 months ago

please unassign this issue i'll comeback later

Zingzy commented 1 month ago

Hi, I would like to work on this issue as a part of hacktoberfest 2024, so please assign this issue to me

Lucas-C commented 1 month ago

Alright @Zingzy, I assigned this issue to you 🙂

Zingzy commented 1 month ago

Hello @Lucas-C I made a PR #58 for this issue, please check 😄

Lucas-C commented 1 month ago

Closing this, it was implemented in https://github.com/py-pdf/pdfly/pull/58