py-pdf / pdfly

CLI tool to extract (meta)data from PDF and manipulate PDF files
BSD 3-Clause "New" or "Revised" License
109 stars 18 forks source link

Add PKCS#12 digital signature with original PDF #72

Open cyy-2024 opened 2 weeks ago

cyy-2024 commented 2 weeks ago

Hello, I added a new sign file and modified the cil file. I also provided a p12 file of the test. You can run the following commands on the CMD:pdfly sign input.pdf --output signed_output.pdf --p12 certs.p12 --password "123456"。 屏幕截图 2024-11-10 084817 This results in a PDF that retains the original PDF and adds the signature text and signature information. If you have any questions, please ask, thanks for giving me the opportunity!

Lucas-C commented 1 week ago

Thank you for starting working on this subject, an welcome on board @cyy-2024! 🙂

First, I would warmly recommend to start initiating some unit tests quite early, in the spirit of test-driven_development. This is a good habit to have when writing software, especially when unit tests are expected in the end for the piece of code you are writing.

You can start with 2 base unit tests:

cyy-2024 commented 1 week ago

I feel sorry,but, thanks for the guidance, please let me try again

Lucas-C commented 1 week ago

I feel sorry,but, thanks for the guidance, please let me try again

Do not feel sorry! 🙂 You did well, and this 1st PR was better and made faster than many first timers on GitHub 👍

My feedbacks are there to let you learn the contribution process on this repository, and to explain why we do things the way we do them 🙂 There is nothing you should feel sorry for.

Take your time on this PR, I'm sure you can do it 👍

Lucas-C commented 5 days ago

Hi @cyy-2024 🙂

Just to get a quick update: do you still want to implement this?

cyy-2024 commented 5 days ago

I'm sorry that the teacher recently arranged for me to develop a project, and it may take at least next week.TT

Lucas-C commented 5 days ago

I'm sorry that the teacher recently arranged for me to develop a project, and it may take at least next week.TT

Alright, no problem!

This can wait, I just wanted to know if you still wanted to continue working on this 🙂

Good luck with your school project!