search

py-pdf / pypdf

A pure-python PDF library capable of splitting, merging, cropping, and transforming the pages of PDF files
https://pypdf.readthedocs.io/en/latest/
Other
7.73k stars 1.36k forks source link

STY: Change deprecation functions to use f-strings #2676

Closed j-t-1 closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.01%. Comparing base (12e4047) to head (d0f9b17).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2676 +/- ## ======================================= Coverage 95.00% 95.01% ======================================= Files 50 50 Lines 8356 8352 -4 Branches 1673 1673 ======================================= - Hits 7939 7936 -3 + Misses 259 258 -1 Partials 158 158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stefan6419846 commented 1 month ago

I disagree with this change. With the current code, we would be able to use the messages for actively filtering deprecation messages if required for some reasons. Converting these to inline messages requires me to manually specify this message.