search

py-pdf / pypdf

A pure-python PDF library capable of splitting, merging, cropping, and transforming the pages of PDF files
https://pypdf.readthedocs.io/en/latest/
Other
8.12k stars 1.39k forks source link

MAINT: Add deprecate_with_replacement to StreamObject.initializeFromD… #2728

Closed j-t-1 closed 3 months ago

j-t-1 commented 3 months ago

…ictionary

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.14%. Comparing base (160ab38) to head (8149847). Report is 66 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2728 +/- ## ======================================= Coverage 95.14% 95.14% ======================================= Files 51 51 Lines 8547 8549 +2 Branches 1703 1703 ======================================= + Hits 8132 8134 +2 Misses 261 261 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pubpub-zz commented 3 months ago

I'm wondering if the comment was not here to ignore coverage only

stefan6419846 commented 3 months ago

@pubpub-zz But we already had the correctly named replacement, but no deprecation warning for it. Thus the comment does not really make sense here and rather looks like an oversight. Nevertheless, we should probably consider adding at least a no coverage pragma to the offending line.