py-pdf / pypdf

A pure-python PDF library capable of splitting, merging, cropping, and transforming the pages of PDF files
https://pypdf.readthedocs.io/en/latest/
Other
8.41k stars 1.42k forks source link

REL: 5.1.0 #2924

Closed stefan6419846 closed 3 weeks ago

stefan6419846 commented 3 weeks ago

After one moment, creating a new release seems like a good idea.

As usual, please do not merge directly after approving to use the correct commit body.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.39%. Comparing base (e2da09f) to head (46abe28). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2924 +/- ## ======================================= Coverage 96.39% 96.39% ======================================= Files 52 52 Lines 8728 8728 Branches 1589 1589 ======================================= Hits 8413 8413 Misses 186 186 Partials 129 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pubpub-zz commented 3 weeks ago

@MartinThoma / @stefan6419846 I let you merge : If you want to try any possible fix for the tag create issue

stefan6419846 commented 3 weeks ago

This time we got another CI error as well:

/home/runner/work/_temp/042f3e83-3caa-4fd1-b3b4-0e81bf8e12d2.sh: line 38: layout_mode_font_height_weight: command not found
/home/runner/work/_temp/042f3e83-3caa-4fd1-b3b4-0e81bf8e12d2.sh: command substitution: line 39: syntax error: unexpected end of file

I have pushed the tag manually and it seems like signing worked here as well, although I got an error message from GitHub:

remote: Bypassed rule violations for refs/tags/5.1.0:
remote: 
remote: - Cannot create ref due to create name restrictions.
remote: 
pubpub-zz commented 3 weeks ago

I have pushed the tag manually and it seems like signing worked here as well, although I got an error message from GitHub:

remote: Bypassed rule violations for refs/tags/5.1.0:
remote: 
remote: - Cannot create ref due to create name restrictions.
remote:

Can you tell me how you pushed it ?

stefan6419846 commented 3 weeks ago

Nothing special:

$ git tag -s "5.1.0" -eF RELEASE_COMMIT_MSG.md
$ git push origin 5.1.0