search

py-pdf / pypdf

A pure-python PDF library capable of splitting, merging, cropping, and transforming the pages of PDF files
https://pypdf.readthedocs.io/en/latest/
Other
8.43k stars 1.42k forks source link

Starting to enrich the annotation module #2935

Open MekJohn opened 3 weeks ago

MekJohn commented 3 weeks ago
  1. I'm incorporating all main parts of annotations as per ISO.
  2. Then I will try to connect those new annotation classes to PdfReader class, in order the read and get same object from and to pdf documents.
  3. Also PdfWriter will be touched in order to be sure that annotation are correctly write the new annotation object.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5b50f47). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pypdf/annotations/_markup_annotations.py 33.33% 23 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2935 +/- ## ======================================= Coverage ? 96.14% ======================================= Files ? 52 Lines ? 8778 Branches ? 1593 ======================================= Hits ? 8440 Misses ? 209 Partials ? 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stefan6419846 commented 3 weeks ago

Thanks for the PR. I suggest to not do everything at once, but in smaller PRs to simplify reviews for us as per the contribution docs. Additionally, I am going to mark this PR as draft for now. Feel free to mark it as ready for review if you think we should have a further look at it.