py-sdl / py-sdl2

Python ctypes wrapper around SDL2
Other
304 stars 49 forks source link

sdlmixer_test: Accept a lower value for sample MP3 duration #244

Closed smcv closed 2 years ago

smcv commented 2 years ago

All the decoders I've tried think sdl2/test/resources/soundtest.mp3 is approximately 0.15 seconds long.

Resolves: https://github.com/py-sdl/py-sdl2/issues/243


PR Description

This fixes a test failure with SDL_mixer 2.6.1 compiled to use libmpg123 for MP3. Debian's versions of extract(1) and Audacity agree that the test file is about 0.15 seconds long.

Merge Checklist

a-hurst commented 2 years ago

Thanks so much! Can you add a quick NOTE comment above the changed line to the effect of "file actually ~0.15s, incorrectly reported as > 0.2s by dr_mp3 backend"? Just so I know to revisit the upper bound if it gets fixed upstream.

smcv commented 2 years ago

Can you add a quick NOTE comment above the changed line

Done

a-hurst commented 2 years ago

@smcv Fantastic, thanks again!