py-smart-gardena / hass-gardena-smart-system

Home Assistant custom component integration for Gardena Smart System
Apache License 2.0
208 stars 52 forks source link

Documentation enhancement proposal #105

Open jlatvala opened 2 years ago

jlatvala commented 2 years ago

vacuum.turn_on and vacuum.turn_off should be added into the README.md.

Maybe add also some description what is the correct or best way to enable automatic operation after using command vacuum.stop (which ignores schedule --> won't ever run again without reactivating) So how to enable "follow schedule" again after vacuum.stop? Calling vacuum.turn_on, I guess?

crazyfx1 commented 2 years ago

Both services are not working at the moment. Currently I'm testing a fix to get them working, I can create a PR in the evening.

grm commented 2 years ago

Hello @crazyfx1 , they seems to be working fine here.

What kind of issue you are facing ? (I did not find an issue from you, maybe create a ticket ? :) )

crazyfx1 commented 2 years ago

The issue is #38. Some time ago I explained there why the commands are not working.

jlatvala commented 2 years ago

Has anyone tested if vacuum.turn_on service works now in 1.0.0-0b901? (it uses new, corrected, py-smart-gardena 1.3.1 version)

If vacuum.turn_on service works (calls Gardena API's START_DONT_OVERRIDE), it should be added into README.md

(sorry, can't test it by myself now)

(also vacuum.turn_off could be added into README.md, even it does the same thing as vacuum.stop)

crazyfx1 commented 2 years ago

vacuum.turn_on and vacuum.turn_off are still not working, nothing was changed in that regard.

Roedandan commented 2 years ago

issue #2 is regarding this as well