Closed knutole closed 1 year ago
The coverage rate went from 93.35%
to 94.78%
:arrow_up:
The branch rate is 88%
.
96.72%
of new lines are covered.
Wow, that's quite a PR. First of all, a big thank you for the work and the interest that you put in this project! I am currently not able to test and review your code, but it looks like you're still at work anyway. So just ping us or request if you need a review.
Thank you 🙏 This PR is now ready for review 👌
It's not possible for me to request review on this PR, by the way, not sure if there's a Github setting for that. @kieferro @johndoknjas
It's not possible for me to request review on this PR, by the way, not sure if there's a Github setting for that. @kieferro @johndoknjas
Ah okay, I see. But it seems that nothing can be done about that as long as you don't have write-access. But feel free to just use the draft PR feature to indicate when the PR is ready for review.
Looks like we're all satisfied with the PR, so I've merged it into master.
Great, thanks 🙏👍
Looks like we're all satisfied with the PR, so I've merged it into master.
Thanks :+1:
Congratulations @knutole. Could you close your two PRs in the old repo (https://github.com/zhelyabuzhsky/stockfish/pull/115, https://github.com/zhelyabuzhsky/stockfish/pull/116)? This would give us a better overview.
This PR combines and replaces https://github.com/py-stockfish/stockfish/pull/14 and https://github.com/py-stockfish/stockfish/pull/15 , with major refactor of
get_top_moves()
function. (It was much easier to combine the PR's, for obvious reasons.) I have left in quite a few comments in the refactor, to make it easier to follow. I will remove most of them once you've had a chance to look it over.get_top_moves()
, remove redundant codeturn_perspective
global option, defaults to Turn perspective. (Note: this means thatget_top_moves()
will change from returning White perspective to returning Turn perspective by default, which is not backwards compatible. See https://github.com/py-stockfish/stockfish/issues/18)self._turn_perspective
self._num_nodes
self._depth
asint
and add public getterget_depth()
. Fixes https://github.com/py-stockfish/stockfish/issues/8set_depth()
,set_num_nodes()
,set_turn_perspective()
Stockfish
class_set_option()
. Remove redundant defaultupdate_parameters_attribute
arguments._pick()
to avoid doingcurrent_line[current_line.index("cp") + 1]
Todo: Add
turn_perspective
option for rest of codebase, see https://github.com/py-stockfish/stockfish/issues/18